fix(tui): clear editor draft on Ctrl-C during compaction - #1076
Merged
Conversation
When compaction is in progress and the editor has a draft, Ctrl-C now clears the draft first instead of cancelling compaction, matching the streaming behavior. The clear-text logic is shared between the compaction and streaming branches.
🦋 Changeset detectedLatest commit: 8fdf196 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No related issue.
Problem
Pressing Ctrl-C while compaction is in progress cancelled the compaction immediately, even when the editor contained a draft. This was inconsistent with streaming, where Ctrl-C clears the editor draft first and only cancels the turn when the editor is empty.
What changed
Ctrl-C now clears a pending editor draft first during compaction, and only cancels the compaction once the editor is empty — matching the existing streaming behavior. The clear-text step is shared between the compaction and streaming branches, so it covers every non-idle turn phase without affecting the BTW panel, in-flight requests, or the idle double-Ctrl-C exit. Added a test covering the compaction case.
Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.