feat(tui): confirm before installing third-party plugins - #1088
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
🦋 Changeset detectedLatest commit: abd226e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
1 similar comment
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b4a9598e8e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| panel, | ||
| selection.entry.source, | ||
| selection.entry.displayName, | ||
| selection.entry.tier === 'official', |
There was a problem hiding this comment.
Verify marketplace install sources before trusting them
When the marketplace comes from /plugins marketplace <file-or-url> or KIMI_CODE_PLUGIN_MARKETPLACE_URL, the catalog is user-controlled; an entry can set tier: "official" while pointing source at a local path or arbitrary URL, and this line then skips the new trust prompt and installs code directly. The Custom and /plugins install paths already use isOfficialPluginSource(source), so marketplace installs should also verify the resolved source (or at least restrict tier-based trust to the default Kimi catalog).
Useful? React with 👍 / 👎.
|
Thanks for the review — both points addressed in P1 (tier spoofing): Marketplace installs now judge trust by the resolved source instead of the catalog P2 (panel not restored on failure): When a third-party install fails, the error branch now re-mounts the marketplace panel ( Added/updated e2e coverage: official marketplace installs (local-file + default catalog) now use the official CDN source so they stay on the no-prompt path, and a new test verifies the panel is restored after a third-party install fails. Full suite is green (1956 passed). |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Related Issue
No prior issue — see Problem below.
Problem
Installing a plugin from the Third-party marketplace tab, the Custom URL tab, or
/plugins install <source>happens immediately on Enter / command submit, with no chance to reconsider. Third-party plugins can bundle MCP servers, skills, and files that run code, so there should be an explicit opt-in before they are installed. Official plugins are unaffected.What changed
tierfor marketplace installs, and by the source URL for Custom //plugins installsources (only the official Kimi CDN path qualifies).Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.