fix(server): skip Unix-only permission check on Windows for server token - #1135
Merged
Conversation
🦋 Changeset detectedLatest commit: d7d6170 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Merged
7723qqq
pushed a commit
to 7723qqq/kimi-code
that referenced
this pull request
Jul 11, 2026
…ken (MoonshotAI#1135) (cherry picked from commit bf51fb7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows, Node.js synthesizes Unix-style file modes from the read-only attribute, so a normal writable private file is reported as mode
666. The server token read path rejected this astoo permissive, expecting mode 0600. Because Windows has no equivalent of Unix owner/group/other permission bits, this check always fails on Windows onceserver.tokenexists on disk.This caused the server/daemon to fail to start after the first run (e.g. after a reboot), breaking
kimi webon Windows.What changed
readPrivateFilenow skips the(mode & 0o077) !== 0check onwin32.tokenStore.currentToken()skips the same check on Windows so live token rotation still works.services-auth.test.tsto run cross-platform round-trip/reuse tests on Windows and keep the Unix-only mode assertions skipped on Windows.Checklist
gen-changesetsskill, or this PR needs no changeset.