chore(deps): upgrade web markdown renderer dependencies - #1155
Conversation
- katex: ^0.16.22 -> ^0.17.0 - markstream-vue: 1.0.3 -> ^1.0.4 - shiki: ^4.2.0 -> ^4.3.0
🦋 Changeset detectedLatest commit: 2d6017c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
❌ Nix build failed Hash mismatch in
Please update |
commit: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba7f812a35
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "katex": "^0.17.0", | ||
| "markstream-vue": "^1.0.4", | ||
| "shiki": "^4.3.0", |
There was a problem hiding this comment.
Update the fixed pnpmDeps hash
Changing these web dependencies updates the dependency graph used by pnpm-lock.yaml, which is included in the Nix derivation source and fed to pkgs.fetchPnpmDeps with a fixed hash in flake.nix:134-153. The CI workflow explicitly runs nix build .#kimi-code in .github/workflows/nix-build.yml:90-108, so with the old pnpmDeps hash left unchanged this dependency upgrade will fail there with a hash mismatch; update the hash in flake.nix to match the new lockfile.
Useful? React with 👍 / 👎.
Required after upgrading katex, markstream-vue, and shiki.
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Related Issue
N/A — routine dependency upgrade.
Problem
The web markdown renderer dependencies in
apps/kimi-webwere several versions behind the latest releases. Upgrading picks up bug fixes and performance improvements for math rendering, streaming markdown, and syntax highlighting.What changed
katex:^0.16.22→^0.17.0markstream-vue:1.0.3→^1.0.4shiki:^4.2.0→^4.3.0Verified with
pnpm install,pnpm --filter @moonshot-ai/kimi-web test,typecheck, andbuild.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.