Skip to content

fix(tui): keep working tips out of the agent swarm progress line - #1189

Merged
liruifengv merged 4 commits into
mainfrom
fix/working-tips-swarm
Jun 29, 2026
Merged

fix(tui): keep working tips out of the agent swarm progress line#1189
liruifengv merged 4 commits into
mainfrom
fix/working-tips-swarm

Conversation

@liruifengv

Copy link
Copy Markdown
Collaborator

Related Issue

N/A — reported directly, no tracking issue.

Problem

Working tips are shown after the moon loader. In agent swarm mode the moon loader moves up into the swarm progress status line, which is immediately followed by the progress bar. Because the tip was written into the shared loader, it leaked into that status line and got squeezed against the progress bar.

What changed

Keep the inline spinner text used by the agent swarm progress line free of tips. The loader still renders the tip on its own row in the activity pane, so non-swarm behavior is unchanged. Added a unit test covering both the inline (no tip) and own-row (with tip) cases.

Checklist

  • I have read the CONTRIBUTING document.
  • I have linked a related issue, or explained the problem above.
  • I have added tests that prove my feature works.
  • Ran gen-changesets skill, or this PR needs no changeset.
  • Ran gen-docs skill, or this PR needs no doc update.

The activity loader is shared between the activity pane and the agent swarm progress status line. Tips were written into the loader, so they leaked into the swarm progress line and got squeezed against the bar. Keep the inline spinner text used by the swarm progress line free of tips, while the loader's own row in the activity pane still shows them.
@changeset-bot

changeset-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1297fd4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@moonshot-ai/kimi-code Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Jun 29, 2026

Copy link
Copy Markdown
pnpm dlx https://pkg.pr.new/@moonshot-ai/kimi-code@1297fd4
npx https://pkg.pr.new/@moonshot-ai/kimi-code@1297fd4

commit: 1297fd4

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2a5b439782

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread apps/kimi-code/src/tui/components/chrome/moon-loader.ts
Comment thread apps/kimi-code/test/tui/components/chrome/moon-loader.test.ts Outdated
MoonLoader starts a real setInterval in its constructor. Stop every loader created in the tests via afterEach so no live timer leaks past the file.
@liruifengv
liruifengv merged commit 04b3492 into main Jun 29, 2026
9 checks passed
@liruifengv
liruifengv deleted the fix/working-tips-swarm branch June 29, 2026 06:21
@github-actions github-actions Bot mentioned this pull request Jun 29, 2026
Moixia pushed a commit to Moixia/idea that referenced this pull request Jun 29, 2026
…nshotAI#1189)

* fix(tui): keep working tips out of the agent swarm progress line

The activity loader is shared between the activity pane and the agent swarm progress status line. Tips were written into the loader, so they leaked into the swarm progress line and got squeezed against the bar. Keep the inline spinner text used by the swarm progress line free of tips, while the loader's own row in the activity pane still shows them.

* test(tui): stop moon loader timers in tests

MoonLoader starts a real setInterval in its constructor. Stop every loader created in the tests via afterEach so no live timer leaks past the file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant