Skip to content

fix: retry empty compaction summaries - #12

Merged
wbxl2000 merged 2 commits into
mainfrom
compaction-empty-summary-retry
May 25, 2026
Merged

fix: retry empty compaction summaries#12
wbxl2000 merged 2 commits into
mainfrom
compaction-empty-summary-retry

Conversation

@wbxl2000

Copy link
Copy Markdown
Collaborator

Summary

  • retry compaction responses that produce an empty or whitespace-only summary
  • validate the summary inside the compaction retry loop before updating conversation history
  • add a changeset for the CLI-visible bug fix

Tests

  • pnpm vitest run packages/agent-core/test/agent/compaction.test.ts
  • pnpm exec oxlint --type-aware packages/agent-core/src/agent/compaction/full.ts packages/agent-core/test/agent/compaction.test.ts

@wbxl2000

Copy link
Copy Markdown
Collaborator Author

@codex

@liruifengv liruifengv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wbxl2000
wbxl2000 merged commit 89ea895 into main May 25, 2026
4 checks passed
@wbxl2000
wbxl2000 deleted the compaction-empty-summary-retry branch May 25, 2026 06:44
@github-actions github-actions Bot mentioned this pull request May 26, 2026
wintrover added a commit to wintrover/kimy that referenced this pull request Jun 29, 2026
- kimy wrapper: move hash writes after smoke test (MoonshotAI#1)
- kimy wrapper: add public/ to web hash inputs (MoonshotAI#3)
- kimy wrapper: widen vis hash to include config files (MoonshotAI#4)
- kimy wrapper: move lockfile from /tmp to ~/.kimy/bin (MoonshotAI#5)
- kimy wrapper: use explicit package list for native hash (MoonshotAI#7)
- 01-bundle.mjs: skip vis-asset build when already done (MoonshotAI#2)
- justfile: sync deploy with new wrapper, add deploy-full (MoonshotAI#9,MoonshotAI#10,MoonshotAI#11)
- flake.nix: add unpin guidance to nixpkgs comment (MoonshotAI#12)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants