feat(web): always show the usage-data opt-out toggle in settings - #1232
Merged
Conversation
The telemetry toggle was hidden unless the config explicitly set a value, and its on/off mapping treated the default (unset) state as off even though telemetry is enabled by default. Show it always, treat unset/true as on, and rename it with a description and a restart note.
🦋 Changeset detectedLatest commit: 6fe0643 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue. This addresses a UX gap found while reviewing the web settings.
Problem
The telemetry opt-out toggle in the web settings was only rendered when the config explicitly contained a
telemetryvalue, so it was hidden in the common default (unset) case. Its on/off mapping also treated the unset default as off, even though telemetry is enabled by default on the backend, which made the switch misleading and meant clicking it wrote a redundanttrueinstead of actually opting out.What changed
trueas on and only explicitfalseas off, matching the backend's opt-out semantics, and fix the click handler so an unset state flips tofalsewhen toggled.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.