feat(tui): include shell commands in input history by liruifengv · Pull Request #1295 · MoonshotAI/kimi-code

liruifengv · 2026-07-02T06:02:22Z

Related Issue

N/A — no related issue; the problem is described below. The approach was discussed and agreed on before implementation.

Problem

The TUI input box supports a shell mode (type ! in an empty box) and input history recall (↑ / ↓). Previously, shell commands were deliberately excluded from input history: because the ! is not stored in the text buffer, a recalled shell command would resurface as a bare command in prompt mode and be sent to the agent instead of being executed. As a result, users could not recall previous shell commands at all.

What changed

Shell commands are now saved to input history with a leading ! marker so they can be told apart from prompts. History recall is mode-aware:

Recalling a !-prefixed entry strips the ! and restores bash mode, so the command runs as a shell command again.
In shell mode, ↑ only cycles through previous shell commands.
In a normal prompt, ↑ browses all history (prompts and shell commands) and switches the editor's mode to match the recalled entry.

This reuses the existing !-prefix convention and is implemented by shadowing the editor's built-in history navigation with a mode-aware version, leaving the rest of the input pipeline unchanged. Existing history entries without a leading ! keep working as prompts, so no migration is needed. Tests and the interaction guides (English and Chinese) are updated accordingly.

Checklist

I have read the CONTRIBUTING document.
I have linked a related issue, or explained the problem above.
I have added tests that prove my feature works.
Ran gen-changesets skill, or this PR needs no changeset.
Ran gen-docs skill, or this PR needs no doc update.

Shell commands entered through the `!` prompt are now saved to input history. Recalling one restores bash mode, and in bash mode Up only cycles through previous shell commands while a normal prompt browses all history.

Note that shell commands are now saved to input history and can be recalled in Shell mode, in both the English and Chinese interaction guides.

changeset-bot · 2026-07-02T06:02:28Z

🦋 Changeset detected

Latest commit: 4a1645f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@moonshot-ai/pi-tui	Patch
@moonshot-ai/kimi-code	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new · 2026-07-02T06:04:15Z

pnpm dlx https://pkg.pr.new/@moonshot-ai/kimi-code@4a1645f

npx https://pkg.pr.new/@moonshot-ai/kimi-code@4a1645f

commit: 4a1645f

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8df8965117

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Add two first-class hooks to the editor's history navigation: setHistoryFilter to limit which entries Up/Down visit, and onRecall to decorate a recalled entry before it is shown. Draft restore, direction-aware cursor placement, and undo behavior are unchanged.

Replace the CustomEditor navigateHistory shadow with pi-tui's setHistoryFilter + onRecall hooks, wired in the editor-keyboard controller. This keeps pi-tui's draft-restore and direction-aware cursor behavior intact (the shadow dropped both) and moves the shell/prompt filtering and mode-restore logic into the business layer.

liruifengv · 2026-07-02T07:00:20Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 839a855dc3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Add onHistoryDraftSave/onHistoryDraftRestore hooks so hosts can stash their own state when entering history browsing and restore it when the user navigates back to the draft. The saved host state is discarded when browsing ends any other way (typing, submit), mirroring the editor draft lifecycle.

Wire pi-tui's history draft save/restore hooks to the editor input mode. Without this, recalling a shell entry and then pressing Down back to an empty draft left the editor in bash mode, so the next typed message was submitted as a shell command.

liruifengv · 2026-07-02T08:17:33Z

@codex review

Fire onHistoryDraftSave before the history filter runs when entering browse, so the host's filter can read the browse-entry mode rather than a mode that changes as entries are recalled. The captured state is still only committed once a matching entry is found.

Lock the history filter to the input mode captured when entering browse. Previously the filter read inputMode live, so after recalling a shell entry (which flips to bash mode) a second Up would only show shell commands.

liruifengv · 2026-07-02T08:56:55Z

@codex

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fcaececa21

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

liruifengv · 2026-07-02T09:15:45Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3d11eb9733

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

liruifengv · 2026-07-02T09:33:46Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d9af718351

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Resolve overlap with #1295 (paste-test editor stub gains setHistoryFilter alongside the new sessionDir harness option) and fold #1296's read-media coordinate warning into the downsampling tip to avoid a duplicated bullet.

liruifengv added 2 commits July 2, 2026 13:58

feat(tui): include shell commands in input history

94507d6

Shell commands entered through the `!` prompt are now saved to input history. Recalling one restores bash mode, and in bash mode Up only cycles through previous shell commands while a normal prompt browses all history.

docs(interaction): document shell command recall in input history

8df8965

Note that shell commands are now saved to input history and can be recalled in Shell mode, in both the English and Chinese interaction guides.

chatgpt-codex-connector Bot reviewed Jul 2, 2026

View reviewed changes

Comment thread apps/kimi-code/src/tui/components/editor/custom-editor.ts Outdated

Comment thread apps/kimi-code/src/tui/components/editor/custom-editor.ts Outdated

liruifengv added 2 commits July 2, 2026 14:57

chatgpt-codex-connector Bot reviewed Jul 2, 2026

View reviewed changes

Comment thread apps/kimi-code/src/tui/controllers/editor-keyboard.ts

liruifengv added 2 commits July 2, 2026 16:17

liruifengv added 2 commits July 2, 2026 16:48

fix(tui): lock history filter to the browse-entry mode

fcaecec

Lock the history filter to the input mode captured when entering browse. Previously the filter read inputMode live, so after recalling a shell entry (which flips to bash mode) a second Up would only show shell commands.

chatgpt-codex-connector Bot reviewed Jul 2, 2026

View reviewed changes

Comment thread apps/kimi-code/src/tui/kimi-tui.ts

chatgpt-codex-connector Bot reviewed Jul 2, 2026

View reviewed changes

Comment thread apps/kimi-code/src/tui/controllers/editor-keyboard.ts

Comment thread apps/kimi-code/src/utils/history/input-history.ts Outdated

chatgpt-codex-connector Bot reviewed Jul 2, 2026

View reviewed changes

Comment thread apps/kimi-code/src/utils/history/input-history.ts Outdated

Comment thread apps/kimi-code/src/tui/controllers/editor-keyboard.ts

liruifengv force-pushed the feat/shell-input-history branch from d7ee8f6 to fcaecec Compare July 2, 2026 09:47

Merge branch 'main' into feat/shell-input-history

4a1645f

liruifengv merged commit 77eb3a9 into main Jul 2, 2026
9 checks passed

liruifengv deleted the feat/shell-input-history branch July 2, 2026 09:59

github-actions Bot mentioned this pull request Jul 2, 2026

ci: release packages #1291

Merged

Uh oh!

Conversation

liruifengv commented Jul 2, 2026

Related Issue

Problem

What changed

Checklist

Uh oh!

changeset-bot Bot commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

pkg-pr-new Bot commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

liruifengv commented Jul 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

liruifengv commented Jul 2, 2026

Uh oh!

liruifengv commented Jul 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

liruifengv commented Jul 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

liruifengv commented Jul 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

changeset-bot Bot commented Jul 2, 2026 •

edited

Loading

pkg-pr-new Bot commented Jul 2, 2026 •

edited

Loading