-
Notifications
You must be signed in to change notification settings - Fork 949
fix(web): cap live session subscriptions to reduce lag with many sessions #1320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
53b6337
fix(web): cap live session subscriptions to reduce lag with many sess…
wbxl2000 8142210
fix(web): reset cursor for sessions evicted from the subscription cap
wbxl2000 6b58c69
fix(web): rebuild evicted sessions from a snapshot on re-open
wbxl2000 a12b756
fix(web): keep stale cursor marker until snapshot succeeds
wbxl2000 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@moonshot-ai/kimi-code": patch | ||
| --- | ||
|
|
||
| Fix the web UI becoming sluggish after opening many sessions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a user has opened more than four sessions, this removes the LRU session from the server-side subscription entirely. The server only broadcasts
isGlobalSessionEventframes to all connections (packages/server/src/services/gateway/wsBroadcastService.ts:112-114), and approval/question request frames are not in that global set (packages/server/src/services/gateway/wsBroadcastService.ts:239-256), so an evicted background session that later reachesevent.question.requestedorevent.approval.requestedwill not populate pending badges or triggeronQuestionRequestednotifications/sounds until the user manually reopens it. That can leave an agent blocked without the existing attention signal in exactly the many-session scenario this cap targets.Useful? React with 👍 / 👎.