-
Notifications
You must be signed in to change notification settings - Fork 938
fix(web): reconcile session from snapshot on reopen #1409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c9064a5
fix(web): reconcile session from snapshot on reopen
wbxl2000 003d0de
fix(web): discard stale snapshot when a newer prompt races reopen
wbxl2000 d051f9b
fix(web): harden reopen snapshot against first-open and optimistic-se…
wbxl2000 d6c18a6
fix(web): keep evicted reopens subscribed when a snapshot races
wbxl2000 829da36
fix(web): let resync snapshots bypass the reopen staleness guard
wbxl2000 c12c423
fix(web): force-apply the snapshot after an undo
wbxl2000 57b06ef
fix(web): gate session reopen on durable seq instead of updatedAt
wbxl2000 4960901
refactor(web): always rebuild reopened sessions from a snapshot
wbxl2000 a5e312c
fix(web): sharpen reopen snapshot discard and skip rebuilds mid-stream
wbxl2000 dc8b992
refactor(web): unconditionally apply session snapshots, drop the stal…
wbxl2000 26d60df
fix(web): preserve loaded older messages when reopen snapshots apply
wbxl2000 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@moonshot-ai/kimi-code": patch | ||
| --- | ||
|
|
||
| web: Fix the end of a reply staying missing after reopening a session. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| // apps/kimi-web/src/lib/snapshotMessages.ts | ||
| // Merge an authoritative snapshot tail into already-loaded messages. | ||
| // | ||
| // The session snapshot returns only the most recent bounded page. After a user | ||
| // has loaded older pages, replacing the whole message array with that tail would | ||
| // drop the older prefix they already fetched and reset scrollback. Preserve any | ||
| // loaded messages older than the snapshot window; the snapshot is authoritative | ||
| // for its own window and replaces anything inside it. | ||
| import type { AppMessage } from '../api/types'; | ||
|
|
||
| export function mergeSnapshotMessages( | ||
| loaded: AppMessage[], | ||
| snapshot: AppMessage[], | ||
| ): AppMessage[] { | ||
| if (snapshot.length === 0) return snapshot; | ||
| if (loaded.length === 0) return snapshot; | ||
|
|
||
| const earliestSnapshotMs = Date.parse(snapshot[0]!.createdAt); | ||
| if (Number.isNaN(earliestSnapshotMs)) return snapshot; | ||
|
|
||
| const older = loaded.filter((message) => { | ||
| const createdAtMs = Date.parse(message.createdAt); | ||
| return !Number.isNaN(createdAtMs) && createdAtMs < earliestSnapshotMs; | ||
| }); | ||
|
|
||
| return older.length > 0 ? [...older, ...snapshot] : snapshot; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a user has already loaded all older messages (
messagesHasMoreBySession[sessionId]is false), reopening a long session now merges that full prefix with the latest snapshot but then resets the pagination flag tosnap.hasMoreMessages. That flag is only relative to the snapshot's bounded tail, so sessions with more than the snapshot page size will incorrectly show “load older” again and issue an unnecessary empty request before returning to false.Useful? React with 👍 / 👎.