fix(tui): keep Edit preview height stable as results land - #1421
Merged
Conversation
🦋 Changeset detectedLatest commit: 21ad136 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
N/A — no prior issue; see Problem below.
Problem
The Edit tool card in the TUI collapses in height and flickers when its result arrives.
tool.call.startedalready carries the finalized arguments, but the preview only applied its line cap after the result landed. For one render tick the card drew the full diff, then snapped back to the capped height, which triggered a full terminal redraw that wiped scrollback and left empty space below the input box.What changed
Apply the Edit preview line cap as soon as the arguments finalize, mirroring the Write tool, instead of waiting for the result. The streaming preview, the finalized-args frame, and the result frame now share the same capped height, so the card no longer grows and collapses.
Verified manually in the TUI with a multi-line edit.
Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.