fix(kimi-web): keep tool components from jumping on expand or collapse - #1433
Conversation
Also show the scroll-to-bottom button whenever scrolled up, and render a fallback icon for tools without a dedicated glyph.
🦋 Changeset detectedLatest commit: af1b5c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9592739e51
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Late-loading media can grow after scrollKey has run; keep chasing the bottom on content growth, and only suppress follow during the pinned expand/collapse window.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac915b6da3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
1 participant
Related Issue
No related issue.
Problem
In the web chat, expanding or collapsing tool components (tool-call groups and individual tool rows) made the conversation jump. The scroll-to-bottom button also only appeared when new messages arrived, so scrolling up through history offered no way back to the latest message, and tools without a dedicated glyph (such as media reads) rendered with a blank where the icon should be.
What changed
grid-template-rows: minmax(0, 0fr)tominmax(0, 1fr)transition instead ofheight: auto, so the expand/collapse is smooth across browsers rather than snapping whereinterpolate-sizeis unsupported.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.