-
Notifications
You must be signed in to change notification settings - Fork 934
fix(web): run new-session slash actions (skills, /goal, /btw) from the empty composer #1445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
670bfd6
fix(web): activate slash skills on the new-session screen
wbxl2000 822238f
fix(web): persist draft modes when a new session is opened via skill
wbxl2000 fd82602
fix(web): await draft-mode profile POST before activating a skill
wbxl2000 8989661
refactor(web): persist draft modes on the skill path only
wbxl2000 a628e31
fix(web): persist draft permission and thinking for new-session skill
wbxl2000 b04f4fb
fix(web): start /goal from the new-session composer
wbxl2000 feccaf4
fix(web): use active-workspace fallback for empty-composer /goal
wbxl2000 3b90fef
fix(web): start /btw from the new-session composer
wbxl2000 5ac7fe1
fix(web): preserve send queue when creating goals
wbxl2000 bca67b6
fix(web): coerce thinking for skill/BTW and handle goal creation fail…
wbxl2000 4edba6f
fix(web): clear staged goal mode when submitting explicit /goal
wbxl2000 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@moonshot-ai/kimi-code": patch | ||
| --- | ||
|
|
||
| web: Fix `/btw [<question>]` opening an empty side chat on the new-session screen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@moonshot-ai/kimi-code": patch | ||
| --- | ||
|
|
||
| web: Fix `/goal <objective>` silently doing nothing on the new-session screen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@moonshot-ai/kimi-code": patch | ||
| --- | ||
|
|
||
| web: Fix slash skill activations (for example `/pre-changelog`) silently doing nothing on the new-session screen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the empty composer receives a non-built-in slash typo such as
/pre-changlog, this branch creates a real backend session beforeactivateSkillcan returnskill.not_found; the optimistic message is removed on failure, but the blank session remains active/in the sidebar. That regresses the documented harmless stray-slash behavior for the new-session screen, so validate the name against the loaded workspace skills (or otherwise avoid creating a session) before taking this creation path.Useful? React with 👍 / 👎.