fix(tui): cap todo panel at 5 rows with overflow indicator - #146
Merged
Conversation
Pick visible todos around in_progress (recent done + upcoming pending), append `+N more` when truncated.
🦋 Changeset detectedLatest commit: 4c35810 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb95a7e5a6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
The previous selector assumed todos were grouped as done...pending when no in_progress existed. On interleaved orderings (the TodoList tool keeps the model-provided order without normalizing) the before and after windows skipped most candidates and produced fewer than five rows. Pick directly from status buckets instead.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
fix #121
Problem
When the agent maintains a long todo list (e.g. ten+ items), the inline
TodoPanelrendered every row, pushing the editor, status line, and recent activity off-screen on short terminals. Users could no longer see what they were typing or what just happened.What changed
MAX_VISIBLE = 5cap to the inline todo panel and a pureselectVisibleTodosselector that picks which rows to show based on status:in_progressitems are kept (capped at 5).pendingitems, while reserving one slot for the most recentdoneitem when both sides have candidates.in_progress: anchor between the last done and the first pending; fall back to first-5 for all-pending, last-5 for all-done.… +N morefooter below the visible rows when the list is truncated.Algorithm and rendering are covered by unit tests for: ≤5 unchanged, in_progress with done/pending context, expansion of done side when pending is short, all-done / all-pending / mixed without in_progress, multiple in_progress, and >5 in_progress capped.
Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.