fix(web): avoid repeated session list scans in sidebar computeds - #1563
Merged
Conversation
🦋 Changeset detectedLatest commit: 4086b95 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue — the problem is explained below.
Problem
With many sessions, the web sidebar visibly stutters. A Chrome Performance recording shows animation-frame tasks of ~87–89 ms against a 16.7 ms frame budget at 60 Hz. Bottom-up attributes ~60 ms (71.5% of the selected range) to
isSessionEffectivelyRunning()re-runningrawState.sessions.find(): the three sidebar list computeds (sessions,sessionsForView,workspaceGroups) each re-scan the whole reactive session array once per row, so the per-frame work grows roughly quadratically with the session count.What changed
isSessionEffectivelyRunning()now takes theAppSessionobject the caller already holds instead of a session id:sessions,sessionsForView, andworkspaceGroupspass the row's session directly — no more per-rowfind()over the whole list.activity(active session only, outside any list loop) keeps a single explicitfind()and passes the result in.false; the BTW side-chat, running-task, and tasks-not-yet-loaded rules are untouched, so all spinner behavior is identical.workspaceIdForSession,toSorted) are intentionally left for a follow-up only if profiling still shows long tasks.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update — internal performance fix with no user-facing behavior change.