fix(web): match current model by id in model picker dropdown - #1565
Merged
Conversation
Model names and display names can collide across providers, so the composer dropdown's checkmark matched by name and lit up every same-named entry. Resolve the current model through its unique id everywhere (dropdown check, thinking controls, status resolution).
🦋 Changeset detectedLatest commit: fa5c2a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue — the problem is explained below.
Problem
In the web UI composer's model quick-switch dropdown, the checkmark for the current model was matched by name (
m.id === status.model || m.model === status.model || m.displayName === status.model). Different providers can serve models with identical display names, so every same-named entry across providers showed a checkmark at once — misleading about which model is actually active.What changed
Match the current model by its unique
AppModel.ideverywhere instead of by name:Composer.vue: the dropdown checkmark condition is nowm.id === status.modelId, consistent with the existingis-currentrow highlight; thecurrentModelcomputed that drives the thinking-level controls also resolves by id.useKimiWebClient.ts:status.modelIdresolution now prefers an exact id match and only falls back to a model-name match, so a bare model name insession.modelstill resolves to a single entry.MobileSettingsSheet.vueandApp.vue(nextThinkingLevel): same id-based resolution for the thinking controls.useModelProviderState.ts:modelByIdprefers exact id match before the name fallback.vue-tsctypecheck and the fullkimi-webvitest suite (380 tests) pass.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.