fix(agent-core/mcp): support tuple array items in JSON Schema sanitizer#1605
fix(agent-core/mcp): support tuple array items in JSON Schema sanitizer#1605creatiVision wants to merge 14 commits into
Conversation
… max_tokens config fields
# Conflicts: # packages/agent-core/src/config/toml.ts # packages/agent-core/src/mcp/connection-manager.ts
🦋 Changeset detectedLatest commit: 5744189 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a2f70e31d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…dation compatibility
|
This branch incorporates a critical schema-compatibility fix that resolves a startup/inference crash when using model providers with strict JSON Schema requirements (specifically the Moonshot/Kimi API validator). The Issue (Continuing from #830)In addition to the circular reference checks introduced in #830, standard MCP servers (like the generative "size": {
"anyOf": [
{ "type": "string", "enum": ["LETTER", "A4", "LEGAL"] },
{ "type": "array", "items": [{"type": "number"}, {"type": "number"}] }
]
}However, the Moonshot/Kimi API validator rejects this structure, enforcing that the What ChangedWe extended With this fix, |
|
Successfully merged upstream origin/main into debian1branch and resolved all conflicts. |
… local running environment
# Conflicts: # packages/server-e2e/test/v2/smoke.test.ts # pnpm-lock.yaml
Related Issue
Resolve #(issue_number)
Problem
What changed
Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.