fix: polish plugin manager hints - #164
Conversation
🦋 Changeset detectedLatest commit: be5397d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
e2dd428 to
e14eaf3
Compare
commit: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e14eaf31f3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| await showPluginMcpPicker(host, selection.pluginId, { | ||
| server: selection.server, | ||
| text: pluginInlineChangeHint(selection.enabled), | ||
| }); |
There was a problem hiding this comment.
When toggling an MCP server other than the first one, this remounts the MCP picker with only a serverHint; PluginMcpSelectorComponent still initializes selectedIndex to 0, so focus jumps back to the first server while the inline success text appears on the toggled row. Because this change also removes the transcript status for interactive toggles, a user who presses Space again expecting to undo the same server can silently toggle the first server instead. Pass the toggled server through as the selected item, similar to the overview picker's selectedId, before remounting.
Useful? React with 👍 / 👎.
|
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
1 participant
Related Issue
No linked issue; this addresses plugin manager UX cleanup from review feedback.
Problem
The interactive
/pluginsmanager mixed keyboard shortcuts into muted text and reported enable/disable changes as transcript status lines, which made repeated plugin toggles noisy and harder to scan.What changed
/pluginsactions reporting status in the transcript, where there is no active picker item to update.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.Test Plan
pnpm exec vitest run apps/kimi-code/test/tui/components/dialogs/plugins-selector.test.ts apps/kimi-code/test/tui/components/dialogs/choice-picker.test.ts apps/kimi-code/test/tui/kimi-tui-message-flow.test.tspnpm --filter @moonshot-ai/kimi-code run typecheckpnpm exec oxlint apps/kimi-code/src/tui/components/dialogs/plugins-selector.ts apps/kimi-code/src/tui/components/dialogs/choice-picker.ts apps/kimi-code/src/tui/kimi-tui.ts apps/kimi-code/test/tui/components/dialogs/plugins-selector.test.ts apps/kimi-code/test/tui/kimi-tui-message-flow.test.ts