fix(kap-server): use HTTP error statuses for session export - #1670
Open
wbxl2000 wants to merge 2 commits into
Open
fix(kap-server): use HTTP error statuses for session export#1670wbxl2000 wants to merge 2 commits into
wbxl2000 wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: dc03712 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
Author
|
@codex review |
commit: |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Follow-up to #1646, which added the Web session export endpoint and has since merged. This follow-up closes the serializer/schema gap found during review.
Problem
The export route declared a binary-only
200response while validation and export failures also returned JSON envelopes with HTTP 200. Fastify could therefore apply the binary response contract to an error object, leaving the Web client with an opaque or malformed failure.What changed
application/zipand declare the JSON error responses separately in the route/OpenAPI contract.defineRoute.Verification
pnpm exec vitest run test/sessions.test.ts test/openapi.test.ts --maxWorkers=1inpackages/kap-server(57 tests)pnpm exec vitest run test/apiSurface.snapshot.test.ts --maxWorkers=1inpackages/kap-serverpnpm exec vitest run test/daemon-client.test.ts --maxWorkers=1inapps/kimi-web(8 tests)pnpm --filter @moonshot-ai/kap-server run typecheckpnpm --filter @moonshot-ai/kimi-web run typecheckgit diff --checkChecklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.