test(kap-server): fix sessions test using removed getHandle API - #1681
Closed
kermanx wants to merge 1 commit into
Closed
test(kap-server): fix sessions test using removed getHandle API#1681kermanx wants to merge 1 commit into
kermanx wants to merge 1 commit into
Conversation
The agent lifecycle refactor (#1624) renamed the agent lookup on IAgentLifecycleService from getHandle(id) to get(id), leaving createBlockedGoalRig in sessions.test.ts calling a method that no longer exists. This broke the typecheck and the two blocked-goal resume tests on main.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue — this fixes a CI failure on main (run 29310725642).
Problem
The agent lifecycle refactor (#1624) renamed the agent lookup on
IAgentLifecycleServicefromgetHandle(id)toget(id).createBlockedGoalRiginpackages/kap-server/test/sessions.test.tsstill calledgetHandle('main'), which broke:TS2339: Property 'getHandle' does not exist, plus a cascading implicit-any)TypeError: getHandle is not a function)What changed
One line:
getHandle('main')→get('main')in the test rig. Verified locally:tsgopasses forpackages/kap-serverand all 53 tests insessions.test.tspass.Checklist
gen-changesetsskill, or this PR needs no changeset. (Test-only change — no changeset per skill rule 5.)gen-docsskill, or this PR needs no doc update. (No user-facing change.)