fix(kosong): restore Kimi preserved-thinking sessions - #1684
Merged
Conversation
🦋 Changeset detectedLatest commit: 1043041 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
RealKai42
marked this pull request as ready for review
July 14, 2026 08:06
commit: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue. The problem was reproduced from exported sessions that could no longer continue after an empty reasoning step.
Problem
Kimi preserved thinking requires
reasoning_contenton historical assistant messages. Older sessions can contain assistant messages without aThinkPartbecause an explicitly empty reasoning step was previously dropped. Withthinking.keepset toall, replaying that history repeatedly fails the request instead of allowing the session to continue.What changed
reasoning_content: ""for assistant history that lacks aThinkPartwhenthinking.keepisalland thinking is not disabled.Validation
pnpm exec vitest run packages/kosong/test— 49 files, 1220 tests passed.pnpm --filter @moonshot-ai/agent-core-v2 test— 237 files, 3361 tests passed.@moonshot-ai/kosongand@moonshot-ai/agent-core-v2.pnpm --filter @moonshot-ai/agent-core-v2 run lint:domainpassed for 855 files.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.