Skip to content

test(agent-core-v2): add lifecycle create stub to sessionLegacy status test #1691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wbxl2000 merged 1 commit into from
Jul 14, 2026
Merged

test(agent-core-v2): add lifecycle create stub to sessionLegacy status test #1691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/agent-core-v2/test/app/sessionLegacy/sessionLegacy.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ describe('Session legacy status (best-effort runtime state)', () => {
dispose: () => {},
};
const agents = {
// create is create-or-get for explicit ids: this session's main agent
// already exists, so return it as-is (same as whenReady).
Comment on lines +86 to +87

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove the inline statement comment

packages/agent-core-v2/AGENTS.md requires comments in this package to live only in the top-of-file /** */ block and says to never place them beside statements; this new explanation is inside the agents object. Move the rationale into the existing file header or drop it so the test stays within the package's documented convention.

Useful? React with 👍 / 👎.

create: () => Promise.resolve(agent),
whenReady: () => Promise.resolve(agent),
} as unknown as IAgentLifecycleService;
const session: ISessionScopeHandle = {
Expand Down
Loading