fix(agent-core-v2): enforce goal deadlines - #1698
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 95b560b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
chengluyu
force-pushed
the
agent/goal-v2-07-wallclock-deadline
branch
from
July 14, 2026 14:53
1a8e411 to
95b560b
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue. This fixes the existing goal wall-clock budget behavior, which could exceed the advertised hard limit while model or tool work was in flight.
Problem
Goal prompts and tools describe wall-clock budgets as hard limits, but both the legacy behavior and the v2 implementation only checked elapsed time at loop checkpoints. A slow model request or tool execution could therefore run well past the configured deadline. User-initiated goal cancellation also needed to remain distinguishable from runtime deadline cancellation.
What changed
userCancelledreason when it happens before the deadline.The change deliberately does not alter v1 checkpoint behavior or implement crash-persistence reconciliation. JavaScript cannot preempt a synchronously blocked event loop, and external work that ignores
AbortSignalmay continue independently after cancellation is requested.Validation:
pnpm --filter @moonshot-ai/agent-core-v2 exec vitest run test/agent/goal/goal.test.ts -t 'hard wall-clock deadline'pnpm --filter @moonshot-ai/agent-core-v2 exec vitest run test/agent/goalpnpm --filter @moonshot-ai/agent-core-v2 typecheckpnpm --filter @moonshot-ai/agent-core-v2 lint:domainpnpm --filter @moonshot-ai/agent-core-v2 testpnpm exec changeset statusgit diff --checkChecklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.