-
Notifications
You must be signed in to change notification settings - Fork 929
feat(agent-core-v2): record compaction droppedCount in wire traces and rename select_tools capability #1707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@moonshot-ai/kimi-code": patch | ||
| --- | ||
|
|
||
| Add the number of messages dropped during compaction retries to the session wire log's LLM request traces. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@moonshot-ai/kimi-code": patch | ||
| --- | ||
|
|
||
| Rename the dynamic tool loading model capability from `select_tools` to `dynamically_loaded_tools`, matching the model catalog vocabulary; the `select_tools` tool and the `tool-select` flag are unchanged. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -315,7 +315,9 @@ function resolveModelCapabilities( | |
| thinking: declared.has('thinking') || declared.has('always_thinking') || detected.thinking, | ||
| tool_use: declared.has('tool_use') || detected.tool_use, | ||
| max_context_tokens: maxContextSize, | ||
| select_tools: declared.has('select_tools') || detected.select_tools === true, | ||
| dynamically_loaded_tools: | ||
| declared.has('dynamically_loaded_tools') || | ||
| detected.dynamically_loaded_tools === true, | ||
|
Comment on lines
+319
to
+320
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
For models configured before this rename with Useful? React with 👍 / 👎. |
||
| }; | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/agent-core-v2/AGENTS.mdsays comments in this tree must live only in the top-of-file block and never beside statements. This new inline explanation violates that package rule; move any needed rationale into the file header or letlogFields: { droppedCount }stand on its own.Useful? React with 👍 / 👎.