fix(web): make code block copy work over plain HTTP - #1714
Merged
Conversation
🦋 Changeset detectedLatest commit: 15e22d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue; this is a focused, reproducible bug fix.
Problem
Code blocks rendered by
markstream-vuesilently skip the clipboard write when Kimi Web is served over plain HTTP and the browser does not exposenavigator.clipboard. The component still shows its copied state, so users see successful feedback while the clipboard remains unchanged. The existing plain-HTTP fallback was only used by locally rendered diff blocks.What changed
copyevent and reuse Kimi Web's existing clipboard fallback when the Clipboard API is unavailable.Verification
pnpm --filter @moonshot-ai/kimi-web test -- clipboard.test.ts(28 files, 492 tests)pnpm --filter @moonshot-ai/kimi-web typecheckpnpm --filter @moonshot-ai/kimi-web buildpnpm --filter @moonshot-ai/kimi-web check:style(baseline mode, no new finding)pnpm exec oxlint --type-aware apps/kimi-web/src/components/chat/Markdown.vueisSecureContext=falseandnavigator.clipboard.writeTextunavailable; clicking the code-block copy button wrote the exact code text to the clipboard.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.