fix: preserve the crash error in diagnostic logs on unexpected exit - #1757
Merged
Conversation
The TUI crash path (uncaughtException / unhandledRejection) logged the error into an asynchronously-drained sink and then called process.exit() on the same tick, so the one line explaining the crash was never written to disk. Flush the diagnostic logs synchronously before exiting.
🦋 Changeset detectedLatest commit: fd53592 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
5 tasks
Merged
7723qqq
pushed a commit
to 7723qqq/kimi-code
that referenced
this pull request
Jul 15, 2026
…oonshotAI#1757) The TUI crash path (uncaughtException / unhandledRejection) logged the error into an asynchronously-drained sink and then called process.exit() on the same tick, so the one line explaining the crash was never written to disk. Flush the diagnostic logs synchronously before exiting.
7723qqq
added a commit
to 7723qqq/kimi-code
that referenced
this pull request
Jul 15, 2026
…oonshotAI#1676 MoonshotAI#1625 MoonshotAI#1746 MoonshotAI#1753 MoonshotAI#1757) Critical fixes cherry-picked from upstream v0.24.x: - fix(agent-core-v2): align rate-limit retries with v1 (MoonshotAI#1598) - fix: preserve empty reasoning across providers (MoonshotAI#1676) - fix: resolve and synchronize thinking effort (MoonshotAI#1625) - fix: align Anthropic-compatible model capabilities (MoonshotAI#1746) - fix(kap-server): close auth bypass via percent-encoded API paths (MoonshotAI#1753) - fix: preserve the crash error in diagnostic logs on unexpected exit (MoonshotAI#1757)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue — the problem is explained below (from a real user report).
Problem
When the interactive CLI dies from an unexpected error (
uncaughtException/unhandledRejection), the crash handler logs the error and immediately callsprocess.exit(1)on the same tick. The diagnostic log sink drains asynchronously, so the single line that explains why the process crashed is still sitting in the in-memory queue at exit and never reaches the log file. We received a user report of the CLI "exiting by itself" mid-turn where the global log contained nothing — consistent with this drop — making such crashes impossible to diagnose from exported sessions.What changed
flushDiagnosticLogsSync()to the diagnostic logging surface (agent-core, re-exported through@moonshot-ai/kimi-code-sdk;RootLoggeritself stays internal). It appends pending entries withappendFileSync, so they survive an immediateprocess.exit().Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.