fix(agent-core-v2): skip no-op agent registration on session resume - #1784
Merged
Merged
Conversation
- SessionMetadata.registerAgent now compares the incoming metadata with the persisted entry (tolerating persisted-JSON artifacts: dropped undefined keys, null parentAgentId, label order) and skips the write entirely when nothing changed - previously the first resume per server process rewrote state.json via the status rollup's ensureMainAgent -> doCreate path, bumping updatedAt and pushing the session to the top of the list
🦋 Changeset detectedLatest commit: ecc9ab8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This was referenced Jul 16, 2026
Merged
Merged
ywh114
pushed a commit
to ywh114/kimi-code
that referenced
this pull request
Jul 19, 2026
…oonshotAI#1784) - SessionMetadata.registerAgent now compares the incoming metadata with the persisted entry (tolerating persisted-JSON artifacts: dropped undefined keys, null parentAgentId, label order) and skips the write entirely when nothing changed - previously the first resume per server process rewrote state.json via the status rollup's ensureMainAgent -> doCreate path, bumping updatedAt and pushing the session to the top of the list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue — the problem is explained below.
Problem
Opening an idle session from the session list (or hitting any read-only endpoint that resolves the session's main agent, such as the status rollup) refreshed the session's "updated" timestamp with no real activity. On the first resume per server process, main-agent materialization re-registered the agent in the session metadata even though the persisted entry was already identical, and that write bumped
updatedAt. The session list then re-sorted the session to the top and the client rendered it as active "just now". Each session was affected once per server process, and again after every server restart.What changed
state.json, no read-model mirror, no change event. The comparison tolerates persisted-JSON artifacts — droppedundefinedkeys,parentAgentId: nullvs absent, label key order, empty vs missing labels — so a pure resume never dirties the document, while any genuine change (a new agent, changed labels, a moved home directory) still goes through the full update path and bumpsupdatedAtas before.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.