fix(agent-core-v2): follow symlinks when loading AGENTS.md and reading files - #1840
Merged
Conversation
🦋 Changeset detectedLatest commit: 73f77fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Merged
This was referenced Jul 17, 2026
7723qqq
pushed a commit
to 7723qqq/kimi-code
that referenced
this pull request
Jul 17, 2026
7723qqq
pushed a commit
to 7723qqq/kimi-code
that referenced
this pull request
Jul 17, 2026
ywh114
pushed a commit
to ywh114/kimi-code
that referenced
this pull request
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
None — the problem is described below.
Problem
The v2 engine's filesystem
statusedlstatsemantics, so symbolic links were never counted as regular files. Two user-visible consequences in the web backend (a common dotfiles setup is installing config/instruction files as symlinks):Readtool rejected symlinked files with"<path>" is not a file., andReadMediaFilesize checks measured the symlink itself instead of its target.The CLI (v1 engine) follows symlinks and handles such files correctly, so CLI and web behavior diverged.
What changed
IHostFileSystem.stataccepts an optionalfollowSymlinksflag; the default keeps the previouslstatsemantics, so other consumers (e.g. directory listings that need to detect symlinks) are unaffected.Read, andReadMediaFilenow stat withfollowSymlinks, matching the v1 CLI behavior.Readtool stats withfollowSymlinks.Skill discovery and MCP config loading were audited for the same problem and are not affected: they use
node:fsdirectly, which already follows symlinks.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.