refactor(agent-core): split RuntimeConfig into Kaos and ToolServices - #185
Merged
Conversation
🦋 Changeset detectedLatest commit: d9e95ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 892b1ce4a8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
N/A — this is a continuation of an in-flight internal refactor.
Problem
The staged refactor split the old
RuntimeConfig(which bundledkaos+ url tools) into two separate fields (kaos: KaosandtoolServices?: ToolServices), but the migration was incomplete:agent.runtimeproperty.kaosnested insidetoolServices(orruntime), causingCannot read properties of undefined (reading 'getcwd')failures.BashToolconstructor signature changed (removed standaloneenvironmentarg) but tests were not updated.runtime.test.tsandbuiltin-current.test.ts.What changed
agent.runtime.kaostoagent.kaos.AgentTestContext) and all session/agent/tool tests to passkaosdirectly toAgent/Sessionconstructors.BashTooltest invocations to embedosEnvintocreateFakeKaos(...)instead of passing it as a third positional arg.Session.instantiateAgentwhere agent cwd was incorrectly set togethome()instead ofgetcwd().@moonshot-ai/agent-coreand@moonshot-ai/kimi-code.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.