fix(agent-core): handle ripgrep cross-device install - #198
Merged
Conversation
🦋 Changeset detectedLatest commit: 0a77da7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 38cd85ebd1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
kermanx
force-pushed
the
xtr/fix-ripgrep-cross-device-copy
branch
from
May 29, 2026 06:36
38cd85e to
0a77da7
Compare
5 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolves #111
Problem
When ripgrep is not available on PATH, the automatic bootstrap extracts
rgunder the system temporary directory and then installs it under the Kimi Code home directory. A directrenamefails withEXDEVwhen those directories are on different filesystems.What changed
Copy the extracted Unix ripgrep binary into a temporary install directory under the target bin directory, apply executable permissions there, then rename it into the final cache path on the same filesystem. This avoids cross-device rename failures while keeping the final cache path from exposing a partial binary.
Added a patch changeset for the agent-core change that enters the CLI bundle.
Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.