-
Notifications
You must be signed in to change notification settings - Fork 875
feat(kap-server): broadcast agent.created/agent.disposed session events #1997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@moonshot-ai/kimi-code": patch | ||
| --- | ||
|
|
||
| Add agent.created and agent.disposed events to the server session event stream, and expose each agent's disposal time in the transcript API. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -235,6 +235,7 @@ export function bindSessionTranscript( | |
| agentDisposables.delete(agentId); | ||
| subscribedAgents.delete(agentId); | ||
| projectors.delete(agentId); | ||
| store.markDisposed(agentId, new Date().toISOString()); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When a session is closed or the daemon restarts, Useful? React with 👍 / 👎. |
||
| }), | ||
| ); | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding these events only to kap-server's private protocol catalog leaves
@moonshot-ai/protocolstale; I verifiedrg "agent.created|agent.disposed" packages/protocolreturns no matches, sopackages/protocol/src/events.tsstill omits these types fromAgentEventandsessionEventMessageSchema. Any SDK/client/test code validating or typing WS frames through the shared package will reject or fail to model events the server now emits.Useful? React with 👍 / 👎.