fix: back off compaction overflow retries by token budget - #211
Merged
Conversation
🦋 Changeset detectedLatest commit: d663d6c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
kermanx
force-pushed
the
xtr/harden-compaction-real-session
branch
from
May 29, 2026 11:03
d418dd7 to
082f468
Compare
kermanx
force-pushed
the
xtr/harden-compaction-real-session
branch
from
May 29, 2026 11:07
082f468 to
d663d6c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d663d6c293
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue. This follows up on #207 after checking the exported session and finding that overflow compaction retries can spend the retry budget on tiny trailing messages.
Problem
When a compaction summary request exceeds the model context window, the retry path used to move the compacted prefix back to the previous safe split only. In the reported session, the tail contained repeated tiny
continueturns and empty assistant placeholders, so each retry reduced the provider input by only a few tokens and never reached the large tool-result messages before the retry budget was exhausted.What changed
minOverflowReductionRatiotoCompactionConfig, defaulting to0.05.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.Validation
pnpm vitest run packages/agent-core/test/agent/compaction.test.ts --testNamePattern "backs off overflow compaction"pnpm vitest run packages/agent-core/test/agent/compaction.test.tspnpm --filter @moonshot-ai/agent-core run typecheckpnpm exec oxlint --type-aware packages/agent-core/src/agent/compaction/strategy.ts packages/agent-core/test/agent/compaction.test.tsgit diff --check