fix(agent-core): only send prompt_cache_key to official OpenAI endpoints - #2240
Open
creatiVision wants to merge 4 commits into
Open
fix(agent-core): only send prompt_cache_key to official OpenAI endpoints#2240creatiVision wants to merge 4 commits into
creatiVision wants to merge 4 commits into
Conversation
…dpoint Since 0.29.0 every OpenAI-compatible provider received the session prompt_cache_key in the request body. Strictly-validating endpoints reject the unknown parameter with a 400, breaking custom providers. Gate the field on the effective base URL targeting api.openai.com (or being unset, which the client defaults there), in both the v1 provider config resolution and the v2 OpenAI chat-completions/responses bases. Vendors that support the field (e.g. Kimi) keep encoding it through their own branch or cacheKey trait hook. Fixes MoonshotAI#2166
…pt cache affinity Data-residency endpoints (eu.api.openai.com, us.api.openai.com) are official OpenAI hosts and accept prompt_cache_key; match any *.api.openai.com hostname instead of the apex only.
The package convention allows comments only in the top-of-file block; move the prompt_cache_key gating notes there.
🦋 Changeset detectedLatest commit: d4510ec The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Tracking / backup of #2203 (original by @B143KC47).
Resolve #2166
If #2203 is merged first, this PR can be closed with no further action.
Problem
Since v0.29.0 (#1970), every OpenAI-compatible provider receives the session
prompt_cache_keyin the request body. Strictly-validating endpoints (e.g. NVIDIA NIM atintegrate.api.nvidia.com) reject the unknown parameter with:That makes custom
openai/openai_responsesproviders unusable for agent sessions.What changed
Same fix as #2203, rebased onto current
main:prompt_cache_keywhen the effective base URL targets the official OpenAI API (api.openai.comor*.api.openai.com, or unset → client default).toKosongProviderConfigforopenaiandopenai_responses(isOfficialOpenAIBaseUrl).cacheKey→prompt_cache_keyfallback in OpenAI chat-completions and Responses bases.Checklist
mainNote
This is a tracking/backup PR so the fix stays visible on the
creatiVisionfork if #2203 stalls. Prefer merging #2203 if it is ready; maintainers should not need both.