fix(vscode): all AskUserQuestions should be answered and added to the… - #2326
Conversation
🦋 Changeset detectedLatest commit: 084dc75 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
would any contributor please review my simple PR? really appreciate it. @liruifengv @wbxl2000 |
commit: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 084dc7530e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const handleAnswer = async (answer: string) => { | ||
| const nextAnswers = { ...answers, [question.question]: answer }; | ||
| if (questionIndex + 1 < questions.length) { |
There was a problem hiding this comment.
When a batched AskUserQuestion has a later item with multi_select: true, this new step-through path still routes every click through a single handleAnswer call and immediately advances or responds. Because the VS Code bridge passes multi_select through, valid batches like single-select Q1 plus multi-select Q2 will submit only the first clicked Q2 label and give the user no way to pick the remaining options, so the agent receives an incomplete answer. Keep per-question multi-selection state and advance only after an explicit submit for those items.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Valid symptom, but for the record: the dialog has never supported multi_select — before this PR a multi-select first question behaved exactly the same (first click submitted immediately), so this isn't introduced by the step-through path. Keeping this PR minimal to fix #2299 (later questions not answerable at all). Multi-select support is tracked in #2463, together with a planned single-form redesign.
|
Thanks for your contribution! |
2 participants
Related Issue
Resolve #(2299)
Problem
In the kimi-code vscode plugin, only the first AskUserQuestion was asked and passe to the context, the rest used the default, which didn't align with user's expectation.
What changed
see detailed changes in this commit
Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.