fix(cli): wrap long approval shell commands - #537
Merged
Conversation
🦋 Changeset detectedLatest commit: f9cf547 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Collaborator
Author
|
To use Codex here, create a Codex account and connect to github. |
Collaborator
Author
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue. This is a focused bug fix for a CLI approval UI problem found during manual testing.
Problem
Long single-line shell commands in approval prompts were truncated to one visible line, so users could not inspect the full command before approving it.
What changed
Wrap shell command blocks in approval prompts with ANSI-aware wrapping while preserving real multi-line command rendering. Added a regression test for a long single-line command and included a patch changeset for the CLI.
Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.Testing
pnpm --filter @moonshot-ai/kimi-code exec vitest run test/tui/components/dialogs/approval-panel.test.tspnpm exec oxlint --type-aware apps/kimi-code/src/tui/components/dialogs/approval-panel.ts apps/kimi-code/test/tui/components/dialogs/approval-panel.test.tspnpm --filter @moonshot-ai/kimi-code typecheckcurrently fails on existing unrelatedpackages/agent-core/src/utils/proxy.tstyping errors forundici/socks.