fix: restore goal resume state from agent records - #552
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 68ab3976c2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
# Conflicts: # packages/agent-core/src/session/index.ts
🦋 Changeset detectedLatest commit: f7db345 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue. This PR fixes goal resume persistence and replay behavior.
Problem
Goal state was still tied to session-level persistence in places, so resumed sessions could miss user-visible goal state and transcript recovery. Forked sessions also needed an ordered, durable way to clear copied goal state without guessing from session metadata.
What changed
forkedwire record so forked sessions clear copied goals during ordered replay while preserving goals created later in the fork.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.Verification
pnpm exec vitest run packages/agent-core/test/agent/records/index.test.ts packages/agent-core/test/agent/records/migration/v1.4.test.ts packages/node-sdk/test/list-sessions.test.ts packages/node-sdk/test/session-plan-compact-usage-resume.test.ts apps/kimi-code/test/tui/message-replay.test.tspnpm exec vitest run packages/node-sdk/test/list-sessions.test.ts packages/node-sdk/test/session-plan-compact-usage-resume.test.ts packages/agent-core/test/agent/records/index.test.ts apps/kimi-code/test/tui/message-replay.test.tspnpm exec oxlint --type-aware packages/agent-core/src/session/store/session-store.ts packages/agent-core/src/agent/records/index.ts packages/agent-core/src/agent/goal/index.ts packages/agent-core/src/agent/records/types.ts packages/node-sdk/test/list-sessions.test.ts packages/node-sdk/test/session-plan-compact-usage-resume.test.ts apps/kimi-code/src/tui/controllers/session-replay.ts apps/kimi-code/test/tui/message-replay.test.tspnpm --filter @moonshot-ai/agent-core run typecheckpnpm --filter @moonshot-ai/kimi-code run typecheckstill fails on the pre-existingsrc/tui/commands/undo.ts(109,54)missing return.Read-only diff audit for context-specific internal identifiers found no issues.