Skip to content

test(kimi-web): keep only pure logic unit tests - #959

Merged
wbxl2000 merged 3 commits into
mainfrom
test/kimi-web-pure-logic
Jun 22, 2026
Merged

test(kimi-web): keep only pure logic unit tests#959
wbxl2000 merged 3 commits into
mainfrom
test/kimi-web-pure-logic

Conversation

@wbxl2000

Copy link
Copy Markdown
Collaborator

Related Issue

No related issue; this was requested directly by the maintainer.

Problem

apps/kimi-web had a large jsdom/component Vitest suite that was expensive to maintain, while the repository's e2e coverage lives in packages/server-e2e. The goal was to remove web component tests but keep a small safety net for high-risk pure logic.

What changed

  • Removed the apps/kimi-web jsdom/component Vitest suite and related test config/deps.
  • Kept existing packages/server-e2e e2e tests unchanged.
  • Added two focused pure-logic Vitest files covering diff parsing, file path links, tool summaries, turn grouping, and todo derivation.
  • Updated apps/kimi-web README/AGENTS and pnpm-lock.yaml.

Validation:

  • pnpm --filter @moonshot-ai/kimi-web run test
  • pnpm --filter @moonshot-ai/kimi-web run typecheck

Checklist

  • I have read the CONTRIBUTING document.
  • I have linked a related issue, or explained the problem above.
  • I have added tests that prove my feature works.
  • Ran gen-changesets skill, or this PR needs no changeset.
  • Ran gen-docs skill, or this PR needs no doc update.

Remove jsdom/component Vitest coverage from apps/kimi-web, keep server-e2e as the e2e path, and add focused pure-logic Vitest coverage for diff parsing, file path links, tool summaries, turn grouping, and todo derivation.
@changeset-bot

changeset-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a3f3bac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

❌ Nix build failed

Hash mismatch in pnpmDeps:

Hash
specified sha256-u+u5Vm6UgrMW/SwiBoSz2WhKp8GOehk4p6euwlinwFI=
got sha256-uE/g32Twhshb5BkROi0UiC8hTnrHxE+DMazPijZnCWo=

Please update flake.nix with the got hash.

@pkg-pr-new

pkg-pr-new Bot commented Jun 22, 2026

Copy link
Copy Markdown
pnpm dlx https://pkg.pr.new/@moonshot-ai/kimi-code@a3f3bac
npx https://pkg.pr.new/@moonshot-ai/kimi-code@a3f3bac

commit: a3f3bac

@wbxl2000
wbxl2000 merged commit 845de6b into main Jun 22, 2026
8 checks passed
@wbxl2000
wbxl2000 deleted the test/kimi-web-pure-logic branch June 22, 2026 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant