test(kimi-web): keep only pure logic unit tests - #959
Merged
Conversation
Remove jsdom/component Vitest coverage from apps/kimi-web, keep server-e2e as the e2e path, and add focused pure-logic Vitest coverage for diff parsing, file path links, tool summaries, turn grouping, and todo derivation.
|
Contributor
|
❌ Nix build failed Hash mismatch in
Please update |
commit: |
# Conflicts: # apps/kimi-web/test/chat-header.test.ts
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No related issue; this was requested directly by the maintainer.
Problem
apps/kimi-webhad a large jsdom/component Vitest suite that was expensive to maintain, while the repository's e2e coverage lives inpackages/server-e2e. The goal was to remove web component tests but keep a small safety net for high-risk pure logic.What changed
apps/kimi-webjsdom/component Vitest suite and related test config/deps.packages/server-e2ee2e tests unchanged.apps/kimi-webREADME/AGENTS andpnpm-lock.yaml.Validation:
pnpm --filter @moonshot-ai/kimi-web run testpnpm --filter @moonshot-ai/kimi-web run typecheckChecklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.