fix: surface provider content filter and preserve context tokens - #963
Merged
7Sageer merged 2 commits intoJun 22, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 1580bb9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
itxaiohanglover
approved these changes
Jun 22, 2026
itxaiohanglover
left a comment
itxaiohanglover
left a comment
There was a problem hiding this comment.
Well-structured fix — surfacing the 'filtered' reason instead of silently treating it as completed is the right behavior. The TUI notice with the raw finish reason is helpful for debugging. Changeset included.
- context: accumulate token estimate for zero-usage steps to preserve the tokenCount / tokenCountCoveredMessageCount invariant - turn/goal: pause the goal when a turn is blocked by safety policy - subagent: surface a filtered child turn as a distinct error - acp: map filtered to the native ACP refusal stop reason - tui: show a filtered-specific message in the btw panel - cli: drop the redundant content_filter suffix from the error message - tests: cover filtered across cli, web, acp, and goal flows
7Sageer
force-pushed
the
fix/provider-filtered-silent-ignore
branch
from
June 22, 2026 09:26
bc49d28 to
1580bb9
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No related issue — this PR fixes a bug observed in a user session where provider safety policy triggers were silently swallowed.
Problem
When the provider returns
content_filter/finishReason: 'filtered', the agent loop currently detects it but theturn.endedevent is emitted withreason: 'completed'. The TUI/CLI gives no indication that the response was blocked, so users see the agent simply stop responding and may repeatedly prompt "continue".Additionally, the context token accounting in
AgentContextoverwrites_tokenCountwith the current step's usage total. For a filtered step the usage is all zeros, so the displayed context token count drops to 0 after the filter.What changed
'filtered'toTurnEndReasonin the protocol schema and wired it throughagent/turnsoturn.endedaccurately reports the reason.'filtered'as an abnormal turn end (error/aborted).'filtered'is treated like other non-completed turns.AgentContextso a step reporting zero usage (e.g. content filter) no longer zeros the accumulated context token count; it falls back to estimating from the covered messages.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.