perf(kaos): stream UTF-8 readLines - #966
Closed
7Sageer wants to merge 1 commit into
Closed
Conversation
🦋 Changeset detectedLatest commit: c82700a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No related issue. This continues the review discussion from PR #962 and fixes the encoding regression found there.
Problem
Reading a large text file through
LocalKaos.readLinesloads the whole file into memory before splitting lines. PR #962 tried to stream UTF-8 reads, but it applied byte-level LF splitting to everyBufferEncoding, which brokeutf16leand changed behavior for lossless encodings such ashex.What changed
LocalKaos.readLinesnow streams UTF-8 files in 64 KiB chunks and keeps only the current unfinished line across chunk boundaries. Non-UTF-8 encodings stay on the previous decode-then-split path so their existing behavior is preserved. Added tests for line-ending fidelity, multi-chunk files, multibyte UTF-8 across the chunk boundary, UTF-8 decode error modes, UTF-16LE splitting, and hex decoding.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.