refactor(web): consolidate localStorage access and split appearance/notification modules - #973
Merged
Merged
Conversation
…otification modules
🦋 Changeset detectedLatest commit: 38861e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
N/A — internal refactor with no user-facing behavior change.
Problem
apps/kimi-web/src/composables/useKimiWebClient.tshad grown to ~4500 lines, acting as a god composable that mixed global state, API wrapping, localStorage persistence, theme/notification management, and more.localStoragereads/writes were scattered across 8+ files, each with duplicatedtry/catchand ad-hoc key constants.What changed
apps/kimi-web/src/lib/storage.tswith safeget/set/remove/JSONhelpers and centralized key constants. Existing key names are preserved unchanged (including the legacykimi-active-workspacenaming).localStorageusage inuseKimiWebClient.ts,App.vue,Composer.vue,ConversationPane.vue,OpenInMenu.vue,useResizable.ts,i18n/index.ts,api/config.ts, anddebug/trace.tsto usestorage.ts.apps/kimi-web/test/storage-logic.test.tswith 13 pure-logic test cases (no jsdom).composables/client/useAppearance.tsandcomposables/client/useNotification.tsfromuseKimiWebClient.ts.maybeNotifyCompletionsouseNotificationdoes not readrawState;useWorkspaceStatewill pass in pre-computed context (isActiveAndVisible,sessionTitle,onClick) in future PRs.useKimiWebClient()as a facade: its return shape, fields, and type exports (Theme,ColorScheme,Accent) are unchanged; no component or call site was modified.Verification
pnpm --filter @moonshot-ai/kimi-web typecheck✅pnpm --filter @moonshot-ai/kimi-web test✅ (22 tests passed)pnpm --filter @moonshot-ai/kimi-web build✅useKimiWebClient.ts: 4529 → 4233 lines.Checklist
gen-changesetsskill.