refactor(agent-core): unify image extension sniff-failed detection - #974
Merged
7Sageer merged 1 commit intoJun 22, 2026
Merged
Conversation
Merge the two duplicate image-extension guards in detectFileType into a single mode-independent rule: an image extension without confirming magic is not an image in any mode. The video extension fallback stays before the NUL check so video containers with no magic still win. No behavior change. Add and align tests: Read rejects an image-extension file with non-image bytes as not readable instead of redirecting to ReadMediaFile; file-type asserts the sniff-failed image case in both media and text modes.
🦋 Changeset detectedLatest commit: d866b78 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Follow-up to #970 (review feedback); no separate issue.
Problem
detectFileTypeexpressed the rule "an image extension without confirming magic is not an image" twice — once in the media-mode branch and once in the text-mode fall-through — each with its own copy of the same comment. The rule is mode-independent, so the duplication forces any future change to this path to be edited in two places, or the two modes silently diverge.Two test gaps from #970 are also closed here: the text-mode behavior change (an image-extension file whose bytes are not an image is reported as
unknownrather thanimage) was not covered by the Read tool tests, and the matching file-type test only exercised text mode while its comment described media mode.What changed
Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.