fix(acp): read workspace local config via local fs at session start - #992
Merged
Conversation
Read `.kimi-code/local.toml` through the persistence (local) kaos instead of the ACP tool kaos during session bootstrap. The ACP reverse-RPC bridge needs the session registered on the client, which is not true until `session/new` returns, so reading through it failed with "unknown session" and blocked new threads in ACP editors such as Zed. Fixes #988
🦋 Changeset detectedLatest commit: a86d78c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #988
Problem
In ACP editors such as Zed, starting a new thread fails with an internal error. During
session/new, the kernel reads the workspace local config (.kimi-code/local.toml) through the ACP reverse-RPC file bridge. The client has not registered the session yet because thesession/newresponse has not returned, so the reversefs/read_text_filecall fails with "unknown session" and aborts session creation. This regressed when the workspace local config was introduced for the add-dir feature.What changed
Read the workspace local config through the persistence (local) kaos instead of the ACP tool kaos in both
createSessionWithOverridesandresumeSessionWithOverrides. This matches the existing design where session-internal system files (AGENTS.md, cwd listing, metadata) are read through the persistence sink so a transient ACP-side failure never blocks bootstrap. The caller-suppliedadditionalDirsare still resolved through the tool kaos, so their semantics are unchanged.Added a regression test that simulates the ACP "unknown session" failure on the tool kaos and verifies session creation still succeeds by reading the local config through the persistence kaos.
Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.