chore(deps): bump mostro-core 0.10 to 0.13.1 - #110
Conversation
- Prerequisite for the protocol v2 migration (transport module)
- Fix map_core_status: add additive Status::WaitingTakerBond/WaitingMakerBond
arms, mapped to None (bond out of scope, no wildcard)
- Gift-wrap path unchanged; app still speaks v1 until feat/transport-v2
- No transitive nostr-sdk bump; build, 81 tests and clippy green
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
WalkthroughThe Changesmostro-core upgrade and status mapping
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
I reviewed the current head and I do not see a blocking issue.
What I checked:
- The dependency bump is isolated to
mostro-core 0.13.1plus the lockfile update. map_core_statusnow handles the additiveWaitingTakerBond/WaitingMakerBondvariants explicitly instead of weakening the match with a wildcard.- Returning
Nonefor those bond-only states is coherent with the stated scope of this PR and preserves exhaustiveness for future upstream enum growth. - I do not see another correctness regression introduced by the patch itself.
Approved on the current revision.
Bumps
mostro-corefrom 0.10.0 to 0.13.1, bringing in thetransportmodule (kind-14 NIP-44 direct messaging). This is the isolated dependency bump — PR #1 of 2 for the protocol v2 migration (spec005-transport-v2-migration). The actual transport switch lands in the follow-upfeat/transport-v2.The app still speaks protocol v1 (gift wrap, kind 1059) after this PR; it compiles and tests pass but is not yet E2E-functional against the v2 node.
Changes
rust/Cargo.toml/Cargo.lock—mostro-core = "0.13.1"rust/src/api/orders.rs— fix the only compile breakage inmap_core_status:order::Statusgains the additiveWaitingTakerBondandWaitingMakerBondvariants. Both map toNone(anti-abuse bond is out of scope), with no wildcard arm so futureStatusvariants keep forcing the match to be revisited.Why straight to 0.13.1
The
transportmodule exists only from 0.13.0; 0.12.1 lacks it and keepsPROTOCOL_VER = 1, so stepping through it adds no value. 0.13.1 is the latest patch.Verification
nip59wrap/unwrap signatures andWrapOptionsare unchanged across the range → gift-wrap path compiles and behaves identically.nostr-sdkbump (stays 0.44.1).cargo build✓ ·cargo test✓ (81 passed) ·cargo clippy✓ (0 errors).crate::api, signatures unchanged.Scope
Out of scope (→
feat/transport-v2): the gift_wrap.rs wrap/unwrap switch, kind-14 subscriptions + author-pin, receive-handler changes. Peer/dispute chat stays on gift wrap throughout.Summary by CodeRabbit