fix: ORDER_STATES.md post-merge corrections - #12
Conversation
- camelCase → kebab-case for all actions (take-sell, add-invoice, etc.) - Fixed admin-cancel → canceled-by-admin (consistent across all tables) - Fixed active color: Blue (not Green) in Appendix E - Fixed cooperativelyCanceled → cooperatively-canceled - Code blocks have proper language tags (text, rust, dart)
|
Caution Review failedPull request was closed or merged during review WalkthroughRenames Mostro protocol state/action identifiers in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.specify/v1-reference/ORDER_STATES.md (1)
379-379:⚠️ Potential issue | 🟠 MajorFix all invalid fenced code block closings in
.specify/v1-reference/ORDER_STATES.md.Closing fences must be plain triple backticks; language identifiers like
text,rust,dartbreak rendering in many Markdown processors. Found 16 invalid closings:
```textat lines: 343, 379, 383, 420, 424, 440, 707, 716```rustat lines: 544, 583, 807, 845```dartat lines: 587, 618, 849, 864Replace all with plain
```.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.specify/v1-reference/ORDER_STATES.md at line 379, Replace all invalid fenced code block closings that include language identifiers with plain triple backticks: find and replace occurrences of "```text", "```rust", and "```dart" used as closing fences in the markdown and change them to "```" so the closing fence is exactly three backticks; specifically update each closing fence instance that currently reads ```text, ```rust, or ```dart to simply ```, ensuring code blocks render correctly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.specify/v1-reference/ORDER_STATES.md:
- Line 455: The status identifier is inconsistent (uses both
`cooperativelyCanceled` and `cooperatively-canceled`); update all occurrences to
the canonical kebab-case `cooperatively-canceled` across the markdown tables and
labels (e.g., replace `cooperativelyCanceled` in the ORDER_STATES table and the
other occurrences referenced like 785 and 797) so every status key and any
related `statusWaiting` mappings use `cooperatively-canceled` consistently.
- Around line 524-529: There is a contradictory transition for event
`add-invoice` when current state is `payment-failed`: one table row
(`payment-failed` + `add-invoice` -> `waiting-payment`) conflicts with later
rows (lines 694-695) that state the status is preserved as `payment-failed`;
pick the intended behavior and make the tables consistent—either change the
first occurrence (`payment-failed` + `add-invoice`) to preserve status
`payment-failed` (so the target/status columns reflect `payment-failed`), or
update the later occurrences (lines referencing `payment-failed` preservation)
to show the transition to `waiting-payment`; ensure both the state column and
resulting status/output columns match for the `payment-failed` + `add-invoice`
transition.
---
Outside diff comments:
In @.specify/v1-reference/ORDER_STATES.md:
- Line 379: Replace all invalid fenced code block closings that include language
identifiers with plain triple backticks: find and replace occurrences of
"```text", "```rust", and "```dart" used as closing fences in the markdown and
change them to "```" so the closing fence is exactly three backticks;
specifically update each closing fence instance that currently reads ```text,
```rust, or ```dart to simply ```, ensuring code blocks render correctly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 7e5ce98d-a84a-4fb2-9c49-a0da2901b612
📒 Files selected for processing (1)
.specify/v1-reference/ORDER_STATES.md
- Fixed cooperativelyCanceled → cooperatively-canceled (line 455) - Fixed code block closing fences (removed language tags from closing) - Fixed payment-failed + add-invoice documentation to match v1 FSM (transitions to waiting-payment, not preserved)
Summary by CodeRabbit
Documentation