chore(clippy): resolve warnings to enable -D warnings gate

[AndreaDiazCorreia]

Prerequisite for #151 (CI with cargo clippy -- -D warnings).

Cleans up the 6 clippy warnings currently on main so the lint can become a required CI check without the first run rebounding.

• Declare cfg(frb_expand) in [lints.rust] (flutter_rust_bridge macro cfg)
• Drop useless anyhow::Error conversion in create_order
• Fix doc lazy-continuation on ResetGuard
• Replace argument-less format! with .to_string()
• Mark unused process_order_event with #[allow(dead_code)]

No behavior change — all fixes are semantic no-ops.

Verified: cargo clippy -- -D warnings clean, cargo test 82 passed / 0 failed.

Summary by CodeRabbit

• Bug Fixes

  • Improved order creation error handling so failed publishes now return a cleaner error while preserving the same rollback behavior.
  • Reduced noise from an internal warning so valid configuration flags are no longer reported as unknown during linting.

• Chores

  • Updated subscription startup messaging and related documentation comments for clearer maintenance.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 507bf465-49f9-4be5-8a56-36b21c0436b5

📥 Commits

Reviewing files that changed from the base of the PR and between 4d00def and 4e71d61.

📒 Files selected for processing (2)

• rust/Cargo.toml
• rust/src/api/orders.rs

---

Walkthrough

This PR adds a Cargo lints configuration to whitelist the frb_expand cfg flag for clippy, and applies small edits to orders.rs: simplified error return in create_order, an added doc comment, a logging call adjustment, and a dead-code annotation on an unused helper.

Changes

Lint Configuration and orders.rs Cleanups

Layer / File(s)	Summary
Clippy unexpected_cfgs whitelist rust/Cargo.toml	Adds a [lints.rust] block with unexpected_cfgs set to warn and a check-cfg entry for cfg(frb_expand).
Order creation error handling and minor cleanups rust/src/api/orders.rs	Returns the caught error directly instead of via .into() in create_order's publish-failure path, adds a doc-comment line near the Kind 38383 subscription guard, switches a startup log message from format! to .to_string(), and annotates the unused process_order_event helper with #[allow(dead_code)].

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

• MostroP2P/app#98: Both PRs touch create_order logic in rust/src/api/orders.rs, including error return and status handling.
• MostroP2P/app#159: Both PRs modify create_order and surrounding subscription logic in rust/src/api/orders.rs to handle failure states.

Suggested reviewers: ermeme

Poem

A cfg flag once caused a fuss,
Clippy grumbled, made a muss.
Now whitelisted, warnings cease,
Orders return errors in peace.
Hop hop hooray, small tweaks done right! 🐇✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the PR’s main goal: resolving Clippy warnings so the -D warnings gate can be enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chore/clippy-warnings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[ermeme]

Code Review Summary

Verdict: APPROVE

I reviewed the current head and found no blocking issues. The manifest change cleanly whitelists frb_expand, and the Rust edits are semantic no-ops.

Verified locally: cargo clippy -- -D warnings passes cleanly.

[Catrya]

tACK