Build names should use dash as separator

[grunch]

In order to keep consistency we should use or all dash or all underscore on name files

Summary by CodeRabbit

• Chores
  • Updated build workflow configuration to improve packaging command parsing for Linux, macOS, and Windows distributions.

[coderabbitai]

Walkthrough

A GitHub Actions workflow file is modified to remove trailing backslashes (line continuation characters) from multi-line shell commands used in Linux, macOS, and Windows packaging steps.

Changes

Cohort / File(s)	Summary
Workflow Configuration \.github/workflows/desktop\.yml	Removed trailing backslashes from multi-line packaging commands in Linux, macOS, and Windows build steps, altering shell command parsing behavior

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Critical consideration: Removal of trailing backslashes changes how the shell interprets subsequent lines. Lines following removed backslashes will now be treated as separate commands rather than continuations, which may break packaging workflows. Verify that the intent is to separate commands or that the commands remain functionally correct after this change.
• Review each packaging step (Linux, macOS, Windows) to ensure command structure is valid after backslash removal.
• Confirm the packaging process still produces expected artifacts.

Poem

🐰 A rabbit hops through workflows so grand,
Trimming the backslashes across every land,
Commands now separate, structured so neat,
Let's package it up—what a tidy feat! 📦

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Title Check	⚠️ Warning	The pull request title states "Build names should use dash as separator," which suggests changes related to naming conventions for build files or build artifacts. However, the actual code changes in the .github/workflows/desktop.yml file involve removing trailing backslashes from multi-line packaging commands, which alters shell command parsing behavior. The raw summary explicitly states that "corresponding artifact path references remain unchanged otherwise," indicating that build naming is not actually being modified. The title does not accurately reflect the primary technical change being made, which is about shell command continuation syntax rather than build naming conventions.	The title should be updated to accurately reflect the actual changes being made. A more appropriate title would be something like "Remove line continuation characters from packaging commands in workflow" or "Fix shell command parsing in desktop workflow" to clearly communicate that the changes involve modifying shell syntax in the workflow configuration rather than changing build naming conventions.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-build-name

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 529863b and 15c37de.

📒 Files selected for processing (1)

• .github/workflows/desktop.yml (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: build

🔇 Additional comments (1)

.github/workflows/desktop.yml (1)

140-189: Clarify discrepancy between PR objectives and AI-detected changes.

The PR objectives describe enforcing consistent build naming using dashes as separators, but the AI summary claims that trailing backslashes (line continuation characters) were removed from multi-line shell commands. These are fundamentally different types of changes.

Looking at the provided code:

• Backslashes are present at lines 144, 152, and 161 (valid line continuations)
• Artifact names consistently use dashes (e.g., linux-x64.tar.gz, windows-x64.zip)
• Constructed filenames use dashes throughout (lines 144, 153, 162, 169, 175)

If backslashes were actually removed as the AI summary suggests, the multi-line commands on lines 144–145, 152–153, and 161–162 would be interpreted as separate shell commands and fail. Please clarify whether:

1. Backslashes were removed (which would break these commands)
2. Only artifact naming was changed to enforce dash separators
3. Both changes were made

To verify the actual changes, please confirm:

• Were line continuation characters (backslashes in bash, backticks in PowerShell) removed?
• If so, were the commands refactored to join them on a single line or properly formatted?

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}