fix: rename notfiers → notifiers directory

[ghost]

Summary

• Renamed the misspelled directory lib/features/order/notfiers/ to lib/features/order/notifiers/
• Updated all import statements in Dart source files and test files referencing the old path
• Updated all documentation files under docs/architecture/ referencing the old path

Closes #544

Test plan

• Verify the project compiles without import errors
• Verify all references to order/notfiers/ have been replaced with order/notifiers/

🤖 Generated with Claude Code

Summary by CodeRabbit

• Chores
  • Updated internal file path references for consistency across documentation and source code.

[coderabbitai]

Walkthrough

This pull request corrects a systematic typo throughout the codebase where the directory name and import paths reference notfiers instead of the correct notifiers. Updates span documentation files and source code imports across the order feature module.

Changes

Cohort / File(s)	Summary
Documentation References docs/architecture/LN_ADDRESS_CONFIRMATION.md, docs/architecture/ORDER_CREATION_PROCESS.md, docs/architecture/README.md, docs/architecture/REQUEST_ID_ANALYSIS.md, docs/architecture/SESSION_AND_KEY_MANAGEMENT.md, docs/architecture/TIMEOUT_DETECTION_AND_SESSION_CLEANUP.md	Updated file path references from notfiers/ to notifiers/ directory in code snippets, comments, and "Implementation Files" sections.
Source Code Imports lib/features/order/notifiers/add_order_notifier.dart, lib/features/order/notifiers/order_notifier.dart	Corrected import paths for abstract_mostro_notifier.dart dependency from notfiers/ to notifiers/ directory.
Provider Dependencies lib/features/order/providers/order_notifier_provider.dart	Updated imports for AddOrderNotifier and OrderNotifier classes from notfiers/ to notifiers/ package paths.
Test Mocks test/mocks.dart	Corrected import path for OrderNotifier dependency from notfiers/ to notifiers/ directory.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• UI Refinements for My Trades Screen #116: Modifies the same AbstractMostroNotifier, OrderNotifier, and AddOrderNotifier classes that are being corrected with updated import paths in this PR.
• feat: implement timeout detection and reversal system for orders in waiting-payment and waiting-buyer-invoice #243: Changes behavior within the notifier files (abstract_mostro_notifier.dart, order_notifier.dart) that are referenced with corrected import paths in this PR.
• fix: comprehensive test suite improvements and fixes #125: Also fixes import paths for the same order notifiers in test files, including updates to test/mocks.dart.

Suggested reviewers

• Catrya
• grunch

Poem

🐰 A typo hopped through the code with glee,
"Notfiers" instead of "notifiers"—oh my!
With careful edits, left and right,
The rabbit fixed the spelling blight,
Now paths are straight, and all runs free! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: renaming the misspelled directory from 'notfiers' to 'notifiers', which is the primary objective of the pull request.
Linked Issues check	✅ Passed	All requirements from issue #544 are met: directory renamed and all imports in source files, test files, and documentation updated to reference the corrected path.
Out of Scope Changes check	✅ Passed	All changes are directly related to the directory rename and import path corrections. No unrelated modifications or scope creep detected.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

docs/architecture/TIMEOUT_DETECTION_AND_SESSION_CLEANUP.md (1)

53-56: ⚠️ Potential issue | 🟡 Minor

Adjust the handleEvent snippet to the current method contract.

This snippet documents handleEvent as Future<void> and awaits super.handleEvent(...); that conflicts with current notifier behavior where handleEvent is synchronous.

Based on learnings "In AbstractMostroNotifier, the handleEvent method is synchronous and returns void, not Future. Do not suggest adding await to super.handleEvent() calls as this would cause compilation errors."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@docs/architecture/TIMEOUT_DETECTION_AND_SESSION_CLEANUP.md` around lines 53 -
56, The documented snippet is out of sync: AbstractMostroNotifier.handleEvent is
synchronous and returns void, so update the example to match by changing the
method signature from Future<void> to void and remove the await when calling
super.handleEvent; keep the same parameter names (MostroMessage event, {bool
bypassTimestampGate = false}) and call super.handleEvent(event,
bypassTimestampGate: bypassTimestampGate) without awaiting to avoid compilation
errors.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/architecture/TIMEOUT_DETECTION_AND_SESSION_CLEANUP.md`:
- Line 776: Update the description that references "synthetic event creation" to
accurately reflect the current behavior: replace or rephrase it in the
architecture doc so it describes direct gift-wrap instruction handling performed
by the OrderNotifier (order_notifier.dart / OrderNotifier) instead of implying
synthetic message/event creation; ensure the sentence clearly states that
OrderNotifier applies direct gift-wrap instructions and does not generate
synthetic events to avoid contradiction with the rest of the timeout
architecture.

---

Outside diff comments:
In `@docs/architecture/TIMEOUT_DETECTION_AND_SESSION_CLEANUP.md`:
- Around line 53-56: The documented snippet is out of sync:
AbstractMostroNotifier.handleEvent is synchronous and returns void, so update
the example to match by changing the method signature from Future<void> to void
and remove the await when calling super.handleEvent; keep the same parameter
names (MostroMessage event, {bool bypassTimestampGate = false}) and call
super.handleEvent(event, bypassTimestampGate: bypassTimestampGate) without
awaiting to avoid compilation errors.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a88cf09f-a2be-4cf6-83b6-af7a810e3513

📥 Commits

Reviewing files that changed from the base of the PR and between e3370f5 and 980a657.

📒 Files selected for processing (11)

• docs/architecture/LN_ADDRESS_CONFIRMATION.md
• docs/architecture/ORDER_CREATION_PROCESS.md
• docs/architecture/README.md
• docs/architecture/REQUEST_ID_ANALYSIS.md
• docs/architecture/SESSION_AND_KEY_MANAGEMENT.md
• docs/architecture/TIMEOUT_DETECTION_AND_SESSION_CLEANUP.md
• lib/features/order/notifiers/abstract_mostro_notifier.dart
• lib/features/order/notifiers/add_order_notifier.dart
• lib/features/order/notifiers/order_notifier.dart
• lib/features/order/providers/order_notifier_provider.dart
• test/mocks.dart

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Update this description to avoid contradicting the current timeout architecture.

Line 776 still says “synthetic event creation,” but this document now describes direct gift-wrap instruction handling without synthetic message creation. Please align wording to prevent confusion.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@docs/architecture/TIMEOUT_DETECTION_AND_SESSION_CLEANUP.md` at line 776,
Update the description that references "synthetic event creation" to accurately
reflect the current behavior: replace or rephrase it in the architecture doc so
it describes direct gift-wrap instruction handling performed by the
OrderNotifier (order_notifier.dart / OrderNotifier) instead of implying
synthetic message/event creation; ensure the sentence clearly states that
OrderNotifier applies direct gift-wrap instructions and does not generate
synthetic events to avoid contradiction with the rest of the timeout
architecture.