File selection cancel logic added#1040
Merged
carsen-stringer merged 1 commit intoMouseLand:mainfrom Feb 11, 2025
Merged
Conversation
Contributor
Author
|
It's just a minor error, but since parent.loaded is used widely throughout the code, it might cause unexpected behavior in other cases. |
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In current version, 9398cac, the gui.io module uses
qtpy.QtWidgets.QFileDialogto prompt the user for an input image.cellpose/cellpose/gui/io.py
Line 108 in 9398cac
However, if the user cancels the file selection,
QFileDialogreturns an empty string, which is then passed toimreadat line 125.cellpose/cellpose/gui/io.py
Lines 125 to 126 in 9398cac
Since
imreadhas its own error handling, all exceptions are suppressed, and line 126 (parent.loaded = True) is executed even if no file is selected.This behavior is undesired, so a simple filename check has been added to return from the _load_image function without setting
parent.loadedtoTrueif no file is selected.