Correct file-filter condition in train_Cellpose-SAM.ipynb#1159
Merged
mrariden merged 1 commit intoMouseLand:mainfrom May 8, 2025
Merged
Correct file-filter condition in train_Cellpose-SAM.ipynb#1159mrariden merged 1 commit intoMouseLand:mainfrom
mrariden merged 1 commit intoMouseLand:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1159 +/- ##
==========================================
- Coverage 52.69% 47.13% -5.57%
==========================================
Files 18 16 -2
Lines 4342 3711 -631
==========================================
- Hits 2288 1749 -539
+ Misses 2054 1962 -92 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What’s changed
The loop was previously using f.name (which does not exist) instead of the proper loop variable name. This change prevents runtime errors and ensures that each filename is handled correctly during dataset assembly.
Original
Fixed
Why this matters
Testing
Ran the script on a directory with mixed filenames (image1.png, image1_seg.png, image1_masks.png, etc.)
No regressions or new errors.