Refactor image conversion functions for improved clarity and error ha…#1183
Merged
Refactor image conversion functions for improved clarity and error ha…#1183
Conversation
…ndling; add comprehensive tests for convert_image functionality.
Collaborator
Author
|
full test passing on ubuntu |
Collaborator
Author
|
gui appears to be working too Guessing will fail for some images: Lines 236 to 266 in 9cb3c29 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
better tests for transforms to catch things we missed previously.
3d image reading fixes and explicit guessing about what the order is in the gui. API is more robust.